Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly fix elephant42 #18908

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Properly fix elephant42 #18908

merged 1 commit into from
Oct 30, 2022

Conversation

fauxpark
Copy link
Member

Description

KC_RSPC still exists as a legacy keycode, for the time being.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added bug keymap via Adds via keymap and/or updates keyboard for via support labels Oct 30, 2022
@fauxpark fauxpark requested a review from a team October 30, 2022 05:51
@fauxpark fauxpark force-pushed the elephant42-proper-fix branch from c45e11f to 201bfad Compare October 30, 2022 05:52
@fauxpark fauxpark force-pushed the elephant42-proper-fix branch from 201bfad to 1dda343 Compare October 30, 2022 05:53
@zvecr zvecr merged commit 594dcbf into qmk:develop Oct 30, 2022
@fauxpark fauxpark deleted the elephant42-proper-fix branch October 30, 2022 15:46
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Properly fix elephant42 (qmk#18908)
7c4d577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr